Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPG-464: Add nodeID to EntityDS SnmpInterfaces queries, IP nodeId column placement #893

Merged
merged 2 commits into from
Oct 2, 2023
Merged

OPG-464: Add nodeID to EntityDS SnmpInterfaces queries, IP nodeId column placement #893

merged 2 commits into from
Oct 2, 2023

Conversation

synqotik
Copy link
Contributor

@synqotik synqotik commented Sep 29, 2023 •
edited
Loading

Part of OPG-464:

  • add nodeId to Entity data source SnmpInterfaces query
  • node nodeId column for IP Interfaces query results

There are more issues in OPG-464 but they require changes to both OpenNMS/Horizon as well as opennms-js first.

Update: removed adding ipInterfaceId to Monitored Services query results, needs to be added to opennms-js first. Also bumped snapshot to 9.0.10.

External References

mikewrosey
mikewrosey previously approved these changes Sep 29, 2023
View reviewed changes
@synqotik synqotik force-pushed the jira/OPG-464-entity-ds-issues branch from d36b523 to a62cfc9 Compare October 2, 2023 13:25
@github-actions github-actions bot added the docs label Oct 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mmahacek
mmahacek approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@mmahacek mmahacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nodeId in IP and SNMP Entity queries against both 31.x and 32.x instances. 👍

@synqotik synqotik merged commit b812263 into release-9.x Oct 2, 2023
12 checks passed
@synqotik synqotik deleted the jira/OPG-464-entity-ds-issues branch October 2, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewrosey mikewrosey mikewrosey approved these changes

@mmahacek mmahacek mmahacek approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@synqotik @mikewrosey @mmahacek