NMS-13115: add FlowSummaryData for improved performance #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swachter
changed the title
fooker
approved these changes
Feb 2, 2021
…ansmitting flow summaries in pipelines
swachter
force-pushed
the
swachter/delay-populate
branch
from
30d84fb
to
b883e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow summaries are determined by creating the "union" over multiple PCollections that contain the flow summaries for certain aggregations. The union operation requires that flow summary information is encoded / decoded. At the moment a
JacksonJsonCoderis used that is not efficient because it is based on reflection and uses JSON as the representation for transmission.Considering the expected amount of generated flow summaries an efficient custom coder for flow summary information should be used. The JSON representation of flow summaries is created at the output stages of the pipeline, i.e. when they are written to Elastic and Kafka.