NMS-13131: Use unaligned windows for different exporters #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…junit tests from being executed)
fooker
requested changes
Mar 10, 2021
main/src/main/java/org/opennms/nephron/UnalignedFixedWindows.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/opennms/nephron/UnalignedFixedWindows.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/opennms/nephron/UnalignedFixedWindows.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Dustin Frisch <fooker@lab.sh>
Naicisum
approved these changes
Mar 11, 2021
fooker
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.opennms.org/browse/NMS-13131
In addition to using unaligned windows, the execution of unit tests by the surefire plugin is reactivated. (Adding jqwik test had the surprising side effect that standard junit tests were no more detected.)