Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-13326: Reduce memory churn #26

Merged
merged 4 commits into from
Jun 17, 2021
Merged

NMS-13326: Reduce memory churn #26

merged 4 commits into from
Jun 17, 2021

Conversation

swachter
Copy link
Contributor

@swachter swachter commented May 28, 2021 •
edited
Loading

Issue: https://issues.opennms.org/browse/NMS-13326

  • Do not deserialize Kafka keys because they are not used later on
  • Change the representation of compound keys (avoid the creation of lots of small objects)

@swachter swachter marked this pull request as ready for review June 8, 2021 16:59
@swachter swachter requested a review from fooker June 8, 2021 17:01
fooker
fooker approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@fooker fooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor optional ideas for improvement

main/src/main/java/org/opennms/nephron/CompoundKey.java Outdated Show resolved Hide resolved
main/src/main/java/org/opennms/nephron/RefType.java Outdated Show resolved Hide resolved
swachter and others added 2 commits June 17, 2021 14:01
@swachter @fooker
Update main/src/main/java/org/opennms/nephron/CompoundKey.java
a146109 
Co-authored-by: Dustin Frisch <fooker@lab.sh>
@swachter @fooker
Update main/src/main/java/org/opennms/nephron/RefType.java
c360c2f 
Co-authored-by: Dustin Frisch <fooker@lab.sh>
@swachter swachter merged commit 74a3bda into master Jun 17, 2021
@swachter swachter deleted the jira/NMS-13326 branch June 17, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fooker fooker fooker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swachter @fooker