-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMS-13545: remove unnecessary fields from FlowSummary / FlowSummaryData #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of questions:
- This alters the output to elasticsearch, right?
- Do we have an feedback from customers if there is any use of this data beside the queries done by OpenNMS itself?
- Do we have a positive test run of the ONMS tests using the altered output format?
private CompoundKeyType parent; | ||
private RefType[] parts; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary
Right.
One customer is running this in production. How would the process be to get feedback from other customers?
The tests in OpenNMS still succeed. |
Not sure. Asking the support team, maybe?
Is there a CI run for this that I haven't found? or was this just done by a local run? |
Will do.
It was a local run. There are no smoke tests for Nephron. All Nephron related tests are under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still has some unnecessary changes. beside that, this is good to merge.
d2983df
to
7a32c55
Compare
Support did not raise objections to dropping these fields. |
Issue: https://issues.opennms.org/browse/NMS-13545