Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-13467: support additonal flow summary accumulation #36

Merged
merged 10 commits into from
Sep 16, 2021

Conversation

swachter
Copy link
Contributor

@swachter swachter commented Sep 14, 2021

Issue: https://issues.opennms.org/browse/NMS-13467

This PR

  • adds the PaneAccumulator class that allows for an additional accumulation of result panes; if the commandline argument --summaryAccumulationDelayMs is non-zero then a PaneAccumulator is inserted into the pipeline

This PR contains some other minor commits that are a byproduct of the main work:

  • The Benchmark application got some changes:
    • Cortex samples of different benchmark runs are differentiated by an additional label; this prevents "data conflicts" between different runs
    • The benchmark application now terminates properly in case of execution exceptions
    • A one-off error was fixed
  • CortexIo got some changes:
    • additional counter metrics are provided that help to differentiate different kinds of Cortex response errors
    • the orgId configuration did not work
    • The implementation could be simplified by using Beam's @Key annotation
  • Pipeline got a small change:
    • The pane- prefix was removed from pane label values

@swachter swachter merged commit 954ac8f into master Sep 16, 2021
@swachter swachter deleted the jira/NMS-13467 branch September 16, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants