Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NMS-13870: Add Nephron documentation #43

Merged
merged 3 commits into from
Jan 23, 2022
Merged

NMS-13870: Add Nephron documentation #43

merged 3 commits into from
Jan 23, 2022

Conversation

indigo423
Copy link
Member

@indigo423 indigo423 commented Dec 21, 2021 •
edited
Loading

Add Antora documentation module and add build step in CircleCI.

As soon this PR is merged we can add it to docs.opennms.com with PR OpenNMS/docs.opennms.com#15.

JIRA: https://issues.opennms.org/browse/NMS-13870

@indigo423 indigo423 mentioned this pull request Dec 21, 2021
Open
Bonrob2
Bonrob2 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@Bonrob2 Bonrob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Nephron docs section looks good. Thanks for doing this. Now I can add the Nephron updates I was working on before the break!

@Bonrob2
Copy link
Contributor

Bonrob2 commented Jan 21, 2022 •
edited
Loading

@indigo423, can we merge this? @RangerRick could you review?

RangerRick
RangerRick approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing but doesn't seem to be related to these changes

@indigo423 indigo423 merged commit 9ce2bfa into master Jan 23, 2022
@indigo423 indigo423 deleted the jira/NMS-13870 branch January 23, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bonrob2 Bonrob2 Bonrob2 approved these changes

@RangerRick RangerRick RangerRick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@indigo423 @Bonrob2 @RangerRick