Fix #102

OpenNTI · Mar 27, 2020 · b25dc4a · b25dc4a
1 parent 0a8c5e4
commit b25dc4a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -6,7 +6,8 @@
 1.1.1 (unreleased)
 ==================
 
-- Nothing changed yet.
+- Fix a faulty assertion error. See `issue 102
+  <https://github.com/NextThought/nti.externalization/issues/102>`_.
 
 
 1.1.0 (2020-03-27)

diff --git a/src/nti/externalization/externalization/externalizer.py b/src/nti/externalization/externalization/externalizer.py
@@ -361,10 +361,8 @@ def to_external_object(
         no decaration
     """
     # Catch the primitives up here, quickly. This catches
-    # numbers, strings, and None. Only do this if we're not on the
-    # second-pass fallback; that means that some representer couldn't handle
-    # a primitive natively (usually a decimal)
-    if name != 'second-pass' and isinstance(obj, PRIMITIVES):
+    # numbers, strings, and None.
+    if isinstance(obj, PRIMITIVES):
         return obj
 
     manager_top = _manager_get() # (name, memos)