Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gemfile to require rack > 2.0 #1273

Closed
OpenNebulaProject opened this issue Nov 20, 2017 · 5 comments
Closed

Update gemfile to require rack > 2.0 #1273

OpenNebulaProject opened this issue Nov 20, 2017 · 5 comments

Comments

@OpenNebulaProject
Copy link


Author Name: Ruben S. Montero (@rsmontero)
Original Redmine Issue: 5244, https://dev.opennebula.org/issues/5244
Original Date: 2017-07-13
Original Assignee: Abel Coronado


None

@OpenNebulaProject
Copy link
Author


Original Redmine Comment
Author Name: Ruben S. Montero (@rsmontero)
Original Date: 2017-07-13T14:58:25Z


Support for rack 1 should be preserved

@OpenNebulaProject
Copy link
Author


Original Redmine Comment
Author Name: Abel Coronado (Abel Coronado)
Original Date: 2017-09-05T14:07:54Z


if RUBY_VERSION < '2.4.0'
    gem 'rack', '< 2.0.0'
else
    gem 'rack', '> 2.0.0'
end

@rsmontero rsmontero modified the milestones: Release 5.6, Release 5.8 Apr 20, 2018
vholer pushed a commit that referenced this issue Feb 1, 2019
vholer pushed a commit that referenced this issue Feb 1, 2019
vholer pushed a commit that referenced this issue Feb 1, 2019
vholer pushed a commit that referenced this issue Feb 1, 2019
@rsmontero
Copy link
Member

Should we add a note on compatibility guide to run install-gems after the upgrade?

@vholer
Copy link
Contributor

vholer commented Feb 4, 2019

Should we add a note on compatibility guide to run install-gems after the upgrade?

Step with install_gems is part of all deployment procedures (fresh new installs or upgrade). I don't think it's necessary to specify it explicitly in the compatibility, but we may tell the Debian* packages are now in conflict with following packages:

  • thin
  • ruby-rack
  • ruby-rack-protection
  • ruby-sinatra

This is something good to know before upgrade. I'll update the docs...

@vholer
Copy link
Contributor

vholer commented Feb 4, 2019

Fixed in OpenNebula/docs#484. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants