Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean shell flags #63

Merged
merged 4 commits into from
Sep 14, 2017
Merged

Fix boolean shell flags #63

merged 4 commits into from
Sep 14, 2017

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Sep 14, 2017

This adds tests for and handles the case where boolean flags should be converted to '--flag' instead of '--flag true'. Fixes #11.

@nellh nellh added the bug label Sep 14, 2017
@nellh nellh self-assigned this Sep 14, 2017
@nellh nellh requested a review from jstiehl September 14, 2017 05:57
Copy link
Contributor

@jstiehl jstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added tests for the false boolean case to test the PR so I thought I would just commit those as well. Works great.

@nellh
Copy link
Contributor Author

nellh commented Sep 14, 2017

Awesome, thank you for the extra tests!

@nellh nellh merged commit ac6c542 into master Sep 14, 2017
@nellh nellh deleted the boolean-shell-handling branch September 21, 2017 03:28
nellh added a commit that referenced this pull request Mar 10, 2020
Move get_snapshot out to the Celery workers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants