Feedback1.2

[OpenOrg-gg]

No description provided.

[dudesahn]

you don't need to set this to address(0), will be that by default

yearn-euler/contracts/Strategy.sol

Line 100 in 12a8137

address public tradeFactory = address(0);

[dudesahn]

for all of the other addresses, you also don't need to re-cast them as address(x)

yearn-euler/contracts/Strategy.sol

Line 101 in 12a8137

address public constant strategistMultisig = address(0x16388463d60FFE0661Cf7F1f31a7D658aC790ff7);

just do

address public constant strategistMultisig = 0x16388463d60FFE0661Cf7F1f31a7D658aC790ff7;

[dudesahn]

you can remove this:

yearn-euler/contracts/Strategy.sol

Line 96 in 12a8137

using SafeERC20 for IERC20;

and this:

yearn-euler/contracts/Strategy.sol

Line 98 in 12a8137

using SafeMath for uint256;

since these are already inherited from baseStrategy

[dudesahn]

yearn-euler/contracts/Strategy.sol

Line 108 in 12a8137

address public assetMarket = address(want);

This doesn't seem to be used anywhere?

[dudesahn]

What are the two addresses here? Would be good to at least have a comment:

yearn-euler/contracts/Strategy.sol

Line 119 in 12a8137

marketsModule.enterMarket(0, address(0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48));

yearn-euler/contracts/Strategy.sol

Line 122 in 12a8137

want.approve(address(0x27182842E098f60e3D576794A5bFFb0777E025d3), type(uint).max);