ColorListWidget: Warn about spot color removal #2209
Conversation
|
Libor, if you want, I would review your PR. |
Yes, please! The text, and maybe the code, may benefit from editing. :) |
|
Counting and reporting the number of affected colors could be a nice addition. If you keep your originial proposal I would suggest to replace "Another map color uses this one as a spot color." |
A color entry may serve as a spot color without direct use in symbols. So far Mapper allowed silent removal of these color entries. This patch adds a warning that triggers when the user tries to remove such a spot color. Co-authored-by: Matthias Kuehlewein <github@kuehlewein.de>
It is possible to enable overprinting simulation and then delete all spot colors. The result is no map display and disabled overprinting simulation option in the menu. The user is locked out of the map content until addition of a new spot color to enable the menu item. This patch makes Mapper react on the absence of spot colors by disabling the overprinting effect. Side remark: MapEditorController::newCheckAction connects the action's triggered() signal to the target slot. Qt documentation clearly states that the signal is not emitted upon setChecked() call. If newCheckAction linked to the toggled() or changed() signals, the call added by this patch might be superfluous.
lpechacek
force-pushed
the
warn-on-spot-color-deletion
branch
from
0ed70f3
to
f59471c
Compare
LGTM. Merged into LibreMapper and squashed into this series. Thanks! |
|
My suggestion is now in GH-2222. |
Whatever solves the problem... Thanks for the enhancements! |
A color entry may serve as a spot color without direct use in symbols. So far Mapper allowed silent removal of these color entries. This patch adds a warning that triggers when the user tries to remove such a spot color.
The problem with disabling the Overprint simulation option while the map is still displayed in overprint mode (as seen in the video further down) is not addressed by this patch. The mechanism for disabling overprint upon the last color deletion seems to be in place but does not work.EDIT: The second patch fixes the problem with disabling the Overprint simulation option presented at the end of the video.
A video documenting the current behavior:
spot-color-no-warning.webm