Warn on spot color deletion #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dl3sdo
requested changes
Apr 15, 2024
|
TBH I'm unhappy with possibly two dialogs appearing. I think it could make use of the detailedText. This would give more room for text, or maybe even for listing the symbols and colors (#2122). |
dg0yt
force-pushed
the
warn-on-spot-color-deletion
branch
2 times, most recently
from
000e793
to
cdf4a71
Compare
dl3sdo
approved these changes
Jun 13, 2024
dl3sdo
requested changes
Jun 13, 2024
dg0yt
force-pushed
the
warn-on-spot-color-deletion
branch
from
cdf4a71
to
1e95cf1
Compare
dl3sdo
approved these changes
Jun 13, 2024
... deleting the last spot color. When overprinting simulation is enabled while deleting the last spot color, the map editor will become empty, and the overprinting action becomes disabled. However, the program didn't actually activate the overprinting simulation mode, so the user was locked out from re-enabling the normal rendering of the map. We must explicitly trigger the action. (Reactions are bound to trigger() to avoid hard-to-debug activation loops from normal state changes.) Co-authored-by: Libor Pechacek <lpechacek@gmx.com>
Allow iterating without binding to the structure. The same pattern is already offered for objects.
A color entry may serve as a spot color without direct use in symbols. So far Mapper allowed silent removal of these color entries. This patch adds a warning which is shown when the user tries to remove such a spot color. Co-authored-by: Matthias Kuehlewein <github@kuehlewein.de> Co-authored-by: Kai Pastor <dg0yt@darc.de>
dg0yt
force-pushed
the
warn-on-spot-color-deletion
branch
from
1e95cf1
to
afa56ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification of GH-2209, GH-2235
overprinting_simulation_actinMapEditorController::spotColorPresenceChanged.