-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show color usage and warn on spot color deletion #2235
Closed
dl3sdo
wants to merge
7
commits into
OpenOrienteering:master
from
dl3sdo:warn-on-spot-color-deletion
Closed
Show color usage and warn on spot color deletion #2235
dl3sdo
wants to merge
7
commits into
OpenOrienteering:master
from
dl3sdo:warn-on-spot-color-deletion
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... deleting the last spot color. When overprinting simulation is enabled while deleting the last spot color, the map editor will become empty, and the overprinting action becomes disabled. However, the program didn't actually activate the overprinting simulation mode, so the user was locked out from re-enabling the normal rendering of the map. We must explicitly trigger the action. (Reactions are bound to trigger() to avoid hard-to-debug activation loops from normal state changes.) Co-authored-by: Libor Pechacek <lpechacek@gmx.com>
A color entry may serve as a spot color without direct use in symbols. So far Mapper allowed silent removal of these color entries. This patch adds a warning which is shown when the user tries to remove such a spot color. Co-authored-by: Matthias Kuehlewein <github@kuehlewein.de> Co-authored-by: Kai Pastor <dg0yt@darc.de>
Add function to return a list of map colors that use a specific spot color. Remove function that just counts these map colors.
Merging the functionality of issuing a warning about spot color removal with the functionality of counting the usage in symbols and objects. As a result just a single warning is showed. Use 'setDetailedText' function to show more details with respect to spot color removal.
Kai, Libor: What do you think? Does this PR meet your functional expectations? |
I couldn't look at it in detail.
|
@dg0yt: Following your suggestions: |
Integrated and merged with #2222. Tnx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user wants to delete a color, the warning message was ambiguous by mixing up symbols and objects (see #2127).
This PR merges #2127, #2222, #2209.
It shows one warning dialog if
In addition the warning messages specifies the number of symbols, objects and other map colors that will be affected by the color removal.
A more detailed warning is available when removing spot colors.