Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enigma2.sh: don't delete GStreamer cache on reboot #2

Merged
merged 1 commit into from
Jul 26, 2015
Merged

enigma2.sh: don't delete GStreamer cache on reboot #2

merged 1 commit into from
Jul 26, 2015

Conversation

athoik
Copy link
Contributor

@athoik athoik commented Jul 24, 2015

No description provided.

littlesat added a commit that referenced this pull request Jul 26, 2015
@littlesat
Merge pull request #2 from athoik/dont_delete_gstreamer_cache
570eba6 
enigma2.sh: don't delete GStreamer cache on reboot
@littlesat littlesat merged commit 570eba6 into OpenPLi:master Jul 26, 2015
@athoik athoik deleted the dont_delete_gstreamer_cache branch July 26, 2015 12:47
eriksl added a commit that referenced this pull request Aug 5, 2016
@eriksl
JESS: patch #2, by adenin
9328182 
This seems to add:

- Unicable command collision detection with a pseudo-random component
- improve frequency display for transponder (apparently in some cases
    the offset frequency needs to be subtracted from the base frequency
    instead of added to)
- switching off tuners in Unicable / JESS mode improved
- remove JESS command hack and replace it by proper code
- add PIN code, no user interface access yet, though

The original commit info seems to be here:
http://www.opena.tv/die-bastelecke/15983-hier-wird-das-neuste-aus-adenins-labor-veroeffentlicht.html#post141869

Changed for OpenPLi:

- merge conflicts
- removed ANSI output (should not be mixed with this feature)

Cherry-picked from Huevos/enigma2@7cf55ed
eriksl added a commit that referenced this pull request Aug 5, 2016
@eriksl
JESS: cleanup unused enum entry DISEQC_WDG introduced by #2.
6e74910 
"Watchdog for buggy DiSEqC-implementation (VuZero)"
eriksl added a commit that referenced this pull request Aug 5, 2016
@eriksl
JESS: move globally used roundMulti function from #2 to a beter place…
3517dc1 
… (dvb.h/dvb.cpp)

This enables the prototype to be checked by the compiler (it's
seen both when compiling the function and when calling it from
another compilation unit and that's how it's supposed to work,
don't add isolated prototypes or external references inside a
source file where it's called, it's useless then).

Remove useless "volatile" qualifier.
eriksl added a commit that referenced this pull request Aug 5, 2016
@eriksl
JESS: replace stray external reference in #2 to crc table by the prop…
9596164 
…er #include.

If the size of the array would ever change, this would lead to
segmentation violations without any compiler errors/warnings.
eriksl added a commit that referenced this pull request Aug 5, 2016
@eriksl
JESS: make function "heterodyne" in #2, which is only used locally, s…
be2ca0c 
…tatic linkage.
eriksl added a commit that referenced this pull request Aug 5, 2016
@eriksl
JESS: Rename more or less obfuscated member function names in #2, pre…
d89b044 
…pareRFmagicCSS and

prepareSTelectronicSatCR, to hopefully more descriptive names.
eriksl added a commit that referenced this pull request Aug 5, 2016
@eriksl
JESS: Some cosmetics for #2.
f0d2f2e
littlesat pushed a commit that referenced this pull request Oct 14, 2016
@Schimmelreiter @littlesat
[Language] Fix global text domain not set #2
17bbeaf 
As usual part #2 :)

One command is not enough, we also need to bind to that domain.
littlesat pushed a commit that referenced this pull request Oct 14, 2016
@Schimmelreiter @littlesat
[Language] Fix global text domain not set #2
d5f7ba1 
As usual part #2 :)

One command is not enough, we also need to bind to that domain.
TwolDE2 referenced this pull request Apr 20, 2018
@MastaG @littlesat
Revert "Remove BH skin files.. (#1471)"
ec61c1e 
This reverts commit 6a59559.
athoik added a commit that referenced this pull request Apr 5, 2020
@athoik
console: fix heap-buffer-overflow on readyRead
d9ae3d9 
This commit fixes a heap-buffer-overflow found using ASAN.
Same issue also seens to occur on readyErrRead, so fix it there as well.

In order to verify that console is not breaking after this commit
a random file was written to stdout using cat.
The file was written to another file and hashes where same on input
file and on output file. That seems enough as a test schenario.
Input file can be created using command: dd if=/dev/urandom of=/tmp/in.dat bs=1 count=1024

        def yellow(self):
                self.container = eConsoleAppContainer()
                self.container.appClosed.append(self.finish)
                self.container.stdoutAvail.append(self.write)
                self.container.setBufferSize(1024)
                catargs = ['/bin/cat', '/tmp/in.dat']
                self.container.execute('/bin/cat', *catargs)

        def finish(self, retval=None):
                self.container.kill()

        def write(self, data):
                file = open('/tmp/out.dat', 'ab')
                file.write(data)
                file.close()

The full error from ASAN follows:
=================================================================
==1014==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x9e176400 at pc 0x00093b98 bp 0xbe9ca384 sp 0xbe9ca37c
WRITE of size 1 at 0x9e176400 thread T0
    #0 0x93b94 in eConsoleAppContainer::readyRead(int) ../../git/lib/base/console.cpp:242
    #1 0x9d1f8 in sigc::bound_mem_functor1<void, eConsoleAppContainer, int>::operator()(int const&) const /usr/include/sigc++-2.0/sigc++/functors/mem_fun.h:2066
    #2 0x9bafc in sigc::adaptor_functor<sigc::bound_mem_functor1<void, eConsoleAppContainer, int> >::deduce_result_type<int const&, void, void, void, void, void, void>::type sigc::adaptor_functor<sigc::bound_mem_functor1<void, eConsoleAppContainer, int> >::operator()<int const&>(int const&) const /usr/include/sigc++-2.0/sigc++/adaptors/adaptor_trait.h:89
    #3 0x99878 in sigc::internal::slot_call<sigc::bound_mem_functor1<void, eConsoleAppContainer, int>, void, int>::call_it(sigc::internal::slot_rep*, int const&) /usr/include/sigc++-2.0/sigc++/functors/slot.h:451
    #4 0x9ae0c in sigc::internal::signal_emit1<void, int, sigc::nil>::emit(sigc::internal::signal_impl*, int const&) /usr/include/sigc++-2.0/sigc++/signal.h:1041
    #5 0x98f68 in sigc::signal1<void, int, sigc::nil>::emit(int const&) const /usr/include/sigc++-2.0/sigc++/signal.h:2951
    #6 0x97854 in sigc::signal1<void, int, sigc::nil>::operator()(int const&) const /usr/include/sigc++-2.0/sigc++/signal.h:2967
    #7 0x95cac in PSignal1<void, int>::operator()(int) ../../git/lib/python/connections.h:67
    #8 0xaaef4 in eSocketNotifier::activate(int) ../../git/lib/base/ebase.h:157
    #9 0xaf070 in eMainloop::processOneEvent(long, _object**, ePyObject) ../../git/lib/base/ebase.cpp:273
    #10 0xafeb8 in eMainloop::iterate(unsigned int, _object**, ePyObject) ../../git/lib/base/ebase.cpp:352
    #11 0xb0400 in eMainloop::poll(ePyObject, ePyObject) ../../git/lib/base/ebase.cpp:379
    #12 0x7446d4 in _wrap_eMainloop_poll python/enigma_python.cpp:5964

0x9e176400 is located 0 bytes to the right of 32768-byte region [0x9e16e400,0x9e176400)
allocated by thread T0 here:
    #0 0xb6a290a0 in operator new(unsigned int) (/usr/lib/libasan.so.5+0x1030a0)
    #1 0x63560 in __gnu_cxx::new_allocator<char>::allocate(unsigned int, void const*) /usr/include/c++/9.2.0/ext/new_allocator.h:114
    #2 0x624c0 in std::allocator_traits<std::allocator<char> >::allocate(std::allocator<char>&, unsigned int) /usr/include/c++/9.2.0/bits/alloc_traits.h:444
    #3 0x63ce4 in std::_Vector_base<char, std::allocator<char> >::_M_allocate(unsigned int) /usr/include/c++/9.2.0/bits/stl_vector.h:343
    #4 0x62d38 in std::vector<char, std::allocator<char> >::_M_default_append(unsigned int) /usr/include/c++/9.2.0/bits/vector.tcc:635
    #5 0x619e8 in std::vector<char, std::allocator<char> >::resize(unsigned int) /usr/include/c++/9.2.0/bits/stl_vector.h:937
    #6 0x91bbc in eConsoleAppContainer::setBufferSize(int) ../../git/lib/base/console.cpp:90
    #7 0x73d040 in eConsolePy_setBufferSize python/enigma_python.cpp:4913
    #8 0xb603b728 in PyEval_EvalFrameEx (/usr/lib/libpython2.7.so.1.0+0xd9728)

SUMMARY: AddressSanitizer: heap-buffer-overflow ../../git/lib/base/console.cpp:242 in eConsoleAppContainer::readyRead(int)
Shadow bytes around the buggy address:
  0x33c2ec30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x33c2ec40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x33c2ec50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x33c2ec60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x33c2ec70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x33c2ec80:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x33c2ec90: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x33c2eca0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x33c2ecb0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x33c2ecc0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x33c2ecd0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==1014==ABORTING
@persianpros persianpros mentioned this pull request May 4, 2021
Closed
@Pr0metheus2 Pr0metheus2 mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@athoik @littlesat