Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing order-dependent test in issue112.IssueTest #135

Merged
merged 1 commit into from Mar 30, 2020

Conversation

OrDTesters
Copy link
Contributor

Currently, test shouldNotFail in issue112.IssueTest fails when run after other tests in JavaLoggerTest. The reason is that tests in JavaLoggerTest set the active logger to be JavaLogger, but shouldNotFail fails when run with this logger. This pull request proposes to explicitly set the logger to be Log4JLogger before shouldNotFail runs, because the test passes when this logger is the active one.

Please let me know if you want to discuss the changes more.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 300

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+95.9%) to 95.913%

Totals Coverage Status
Change from base Build 298: 95.9%
Covered Lines: 3145
Relevant Lines: 3279

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants