Added throwing actor.Crushables initialization checks to Aircraft & L…

…ocomotor.IsBlockedBy(...)

Also changed the wording for HierarchicalPathFinder.ActorIsBlocking(Actor actor).
All three now tell which trait had the error in the error message.
This may lead to more crashes; however, those crashes will report otherwise silent issues.

OpenRA.Mods.Common/Pathfinder/HierarchicalPathFinder.cs

@@ -651,7 +651,7 @@ bool ActorIsBlocking(Actor actor)
 		{
 			var crushables = actor.Crushables;
 			if (crushables == null)
-				throw new InvalidOperationException($"Actor {actor} is still in the process of being created. Cannot determine if it is blocking.");
+				throw new InvalidOperationException($"Actor {actor.Info.Name} is still in the process of being created. HierarchicalPathFinder cannot determine if it is blocking.");
 
 			var isMovable = actor.OccupiesSpace is Mobile mobile && !mobile.IsTraitDisabled && !mobile.IsTraitPaused && !mobile.IsImmovable;
 			if (isMovable)

OpenRA.Mods.Common/Traits/Air/Aircraft.cs

@@ -692,6 +692,10 @@ bool IsBlockedBy(Actor self, Actor otherActor, Actor ignoreActor, bool blockedBy
 			if (otherActor == self || otherActor == ignoreActor)
 				return false;
 
+			var crushables = otherActor.Crushables;
+			if (crushables == null)
+				throw new InvalidOperationException($"Actor {otherActor.Info.Name} is still in the process of being created. Aircraft cannot determine if it is blocking.");
+
 			// We are not blocked by actors we can nudge out of the way
 			// TODO: Generalize blocker checks and handling here and in Locomotor
 			if (!blockedByMobile && self.Owner.RelationshipWith(otherActor.Owner) == PlayerRelationship.Ally &&
@@ -713,7 +717,7 @@ bool IsBlockedBy(Actor self, Actor otherActor, Actor ignoreActor, bool blockedBy
 
 			// If the other actor in our way cannot be crushed, we are blocked.
 			// PERF: Avoid LINQ.
-			foreach (var crushable in otherActor.Crushables)
+			foreach (var crushable in crushables)
 				if (crushable.CrushableBy(otherActor, self, Info.Crushes))
 					return false;
 

OpenRA.Mods.Common/Traits/World/Locomotor.cs

@@ -346,6 +346,10 @@ bool IsBlockedBy(Actor actor, Actor otherActor, Actor ignoreActor, CPos cell, Bl
 			if (otherActor == ignoreActor)
 				return false;
 
+			var crushables = otherActor.Crushables;
+			if (crushables == null)
+				throw new InvalidOperationException($"Actor {otherActor.Info.Name} is still in the process of being created. Locomotor cannot determine if it is blocking.");
+
 			var otherMobile = otherActor.OccupiesSpace as Mobile;
 			var otherIsMovable = otherMobile != null && !otherMobile.IsTraitDisabled && !otherMobile.IsTraitPaused && !otherMobile.IsImmovable;
 			var otherIsMoving = otherIsMovable && otherMobile.CurrentMovementTypes.HasMovementType(MovementType.Horizontal);
@@ -380,7 +384,6 @@ bool IsBlockedBy(Actor actor, Actor otherActor, Actor ignoreActor, CPos cell, Bl
 
 			// If the other actor in our way cannot be crushed, we are blocked.
 			// PERF: Avoid LINQ.
-			var crushables = otherActor.Crushables;
 			foreach (var crushable in crushables)
 				if (crushable.CrushableBy(otherActor, actor, Info.Crushes))
 					return false;