Fix SubCell indexing in Map.CenterOfSubCell and MapGrid.OffsetOfSubCell

OpenRA · Nov 2, 2018 · 5899636 · 5899636
1 parent 8f1d8a6
commit 5899636
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/OpenRA.Game/Map/Map.cs b/OpenRA.Game/Map/Map.cs
@@ -786,7 +786,7 @@ public WPos CenterOfCell(CPos cell)
 		public WPos CenterOfSubCell(CPos cell, SubCell subCell)
 		{
 			var index = (int)subCell;
-			if (index >= 0 && index <= Grid.SubCellOffsets.Length)
+			if (index >= 0 && index < Grid.SubCellOffsets.Length)
 				return CenterOfCell(cell) + Grid.SubCellOffsets[index];
 			return CenterOfCell(cell);
 		}

diff --git a/OpenRA.Game/Map/MapGrid.cs b/OpenRA.Game/Map/MapGrid.cs
@@ -168,7 +168,11 @@ public WVec OffsetOfSubCell(SubCell subCell)
 			if (subCell == SubCell.Invalid || subCell == SubCell.Any)
 				return WVec.Zero;
 
-			return SubCellOffsets[(int)subCell];
+			var index = (int)subCell;
+			if (index >= 0 && index < SubCellOffsets.Length)
+				return SubCellOffsets[index];
+
+			return WVec.Zero;
 		}
 	}
 }