Skip to content

Commit

Permalink
Replace highlight palette with tint effects.
Browse files Browse the repository at this point in the history
  • Loading branch information
pchote committed Jan 1, 2021
1 parent 3484add commit 6e3a366
Show file tree
Hide file tree
Showing 10 changed files with 55 additions and 84 deletions.
9 changes: 6 additions & 3 deletions OpenRA.Game/Traits/Player/FrozenActorLayer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,12 @@ public IEnumerable<IRenderable> Render(WorldRenderer wr)

if (flashTicks > 0 && flashTicks % 2 == 0)
{
var highlight = wr.Palette("highlight");
return Renderables.Concat(Renderables.Where(r => !r.IsDecoration && r is IPalettedRenderable)
.Select(r => ((IPalettedRenderable)r).WithPalette(highlight)));
return Renderables.Concat(Renderables.Where(r => !r.IsDecoration && r is IModifyableRenderable)
.Select(r =>
{
var mr = (IModifyableRenderable)r;
return mr.WithTint(float3.Ones, mr.TintModifiers | TintModifiers.ReplaceColor).WithAlpha(0.5f);
}));
}

return Renderables;
Expand Down
47 changes: 0 additions & 47 deletions OpenRA.Game/Traits/Player/PlayerHighlightPalette.cs

This file was deleted.

10 changes: 7 additions & 3 deletions OpenRA.Mods.Common/Effects/FlashTarget.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,14 @@ public IEnumerable<IRenderable> Render(WorldRenderer wr)
{
if (target.IsInWorld && tick >= 0 && tick % interval == 0)
{
var palette = wr.Palette(player == null ? "highlight" : "highlight" + player.InternalName);
var color = player == null ? float3.Ones : new float3(player.Color.R, player.Color.G, player.Color.B) / 255f;
return target.Render(wr)
.Where(r => !r.IsDecoration && r is IPalettedRenderable)
.Select(r => ((IPalettedRenderable)r).WithPalette(palette));
.Where(r => !r.IsDecoration && r is IModifyableRenderable)
.Select(r =>
{
var mr = (IModifyableRenderable)r;
return mr.WithTint(color, mr.TintModifiers | TintModifiers.ReplaceColor).WithAlpha(0.5f);
});
}

return SpriteRenderable.None;
Expand Down
10 changes: 7 additions & 3 deletions OpenRA.Mods.Common/Traits/World/EditorActorPreview.cs
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,13 @@ public IEnumerable<IRenderable> Render()
var items = previews.SelectMany(p => p.Render(worldRenderer, CenterPosition));
if (Selected)
{
var highlight = worldRenderer.Palette("highlight");
var overlay = items.Where(r => !r.IsDecoration && r is IPalettedRenderable)
.Select(r => ((IPalettedRenderable)r).WithPalette(highlight));
var overlay = items.Where(r => !r.IsDecoration && r is IModifyableRenderable)
.Select(r =>
{
var mr = (IModifyableRenderable)r;
return mr.WithTint(float3.Ones, mr.TintModifiers | TintModifiers.ReplaceColor).WithAlpha(0.5f);
});

return items.Concat(overlay);
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
#region Copyright & License Information
/*
* Copyright 2007-2020 The OpenRA Developers (see AUTHORS)
* This file is part of OpenRA, which is free software. It is made
* available to you under the terms of the GNU General Public License
* as published by the Free Software Foundation, either version 3 of
* the License, or (at your option) any later version. For more
* information, see COPYING.
*/
#endregion

using System.Collections.Generic;

namespace OpenRA.Mods.Common.UpdateRules.Rules
{
public class RemovePlayerHighlightPalette : UpdateRule
{
public override string Name { get { return "PlayerHighlightPalette trait has been removed."; } }

public override string Description
{
get
{
return "PlayerHighlightPalette trait has been removed. Its functionality is now automatically provided by the engine.";
}
}

public override IEnumerable<string> UpdateActorNode(ModData modData, MiniYamlNode actorNode)
{
actorNode.RemoveNodes("PlayerHighlightPalette");
yield break;
}
}
}
1 change: 1 addition & 0 deletions OpenRA.Mods.Common/UpdateRules/UpdatePath.cs
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public class UpdatePath
{
// Bleed only changes here
new RenameMPTraits(),
new RemovePlayerHighlightPalette(),
})
};

Expand Down
7 changes: 0 additions & 7 deletions mods/cnc/rules/palettes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,6 @@
G: 0
B: 0
A: 140
PaletteFromRGBA@highlight:
Name: highlight
R: 255
G: 255
B: 255
A: 128
PaletteFromRGBA@moveflash:
Name: moveflash
R: 255
Expand All @@ -115,7 +109,6 @@
PlayerColorPalette:
BasePalette: terrain
RemapIndex: 176, 178, 180, 182, 184, 186, 189, 191, 177, 179, 181, 183, 185, 187, 188, 190
PlayerHighlightPalette:
MenuPaletteEffect:
MenuEffect: Desaturated
CloakPaletteEffect:
Expand Down
7 changes: 0 additions & 7 deletions mods/d2k/rules/palettes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@
G: 0
B: 0
A: 140
PaletteFromRGBA@highlight:
Name: highlight
R: 255
G: 255
B: 255
A: 128
PaletteFromEmbeddedSpritePalette@moveflash-base:
Name: moveflash-base
Image: moveflsh
Expand Down Expand Up @@ -78,7 +72,6 @@
BasePalette: player
Alpha: 0.68
Premultiply: false
PlayerHighlightPalette:
FlashPaletteEffect:
PaletteFromPlayerPaletteWithAlpha@cloak:
BaseName: cloak
Expand Down
7 changes: 0 additions & 7 deletions mods/ra/rules/palettes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,6 @@
G: 0
B: 0
A: 140
PaletteFromRGBA@highlight:
Name: highlight
R: 255
G: 255
B: 255
A: 128
PaletteFromRGBA@moveflash:
Name: moveflash
R: 255
Expand Down Expand Up @@ -100,7 +94,6 @@
BaseName: cloak
BasePalette: player
Alpha: 0.55
PlayerHighlightPalette:
MenuPaletteEffect:
RotationPaletteEffect@defaultwater:
Palettes: terrain
Expand Down
7 changes: 0 additions & 7 deletions mods/ts/rules/palettes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,6 @@
G: 0
B: 0
A: 140
PaletteFromRGBA@highlight:
Name: highlight
R: 255
G: 255
B: 255
A: 128
PaletteFromRGBA@moveflash:
Name: moveflash
R: 255
Expand Down Expand Up @@ -161,7 +155,6 @@
BasePalette: terraindecoration
Name: terrainalpha
Alpha: 0.55
PlayerHighlightPalette:
MenuPaletteEffect:
GlobalLightingPaletteEffect:
ExcludePalettes: cursor, chrome, colorpicker, fog, shroud, alpha, effect-ignore-lighting, effect-ignore-lighting-alpha25, effect-ignore-lighting-alpha50, effect-ignore-lighting-alpha75, greentiberium, bluetiberium

0 comments on commit 6e3a366

Please sign in to comment.