Fix RCS1239

OpenRA · Oct 30, 2023 · 75a4ab2 · 75a4ab2
1 parent 59fa705
commit 75a4ab2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -1120,3 +1120,6 @@ dotnet_diagnostic.RCS1233.severity = warning
 
 # Optimize method call.
 dotnet_diagnostic.RCS1235.severity = warning
+
+# Use 'for' statement instead of 'while' statement.
+dotnet_diagnostic.RCS1239.severity = warning
diff --git a/OpenRA.Mods.Common/FileFormats/Blast.cs b/OpenRA.Mods.Common/FileFormats/Blast.cs
@@ -214,8 +214,7 @@ public BitReader(Stream stream)
 		public int ReadBits(int count)
 		{
 			var ret = 0;
-			var filled = 0;
-			while (filled < count)
+			for (var filled = 0; filled < count; filled++)
 			{
 				if (bitCount == 0)
 				{
@@ -226,7 +225,6 @@ public int ReadBits(int count)
 				ret |= (bitBuffer & 1) << filled;
 				bitBuffer >>= 1;
 				bitCount--;
-				filled++;
 			}
 
 			return ret;