Extract hard-coded FPS limiter with parameter.

OpenRA · Jul 25, 2023 · 953c4d1 · 953c4d1
1 parent 4349c1a
commit 953c4d1
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/OpenRA.Mods.Common/Widgets/Logic/Settings/DisplaySettingsLogic.cs b/OpenRA.Mods.Common/Widgets/Logic/Settings/DisplaySettingsLogic.cs
@@ -63,6 +63,8 @@ public class DisplaySettingsLogic : ChromeLogic
 		[TranslationReference]
 		const string Disabled = "options-target-lines.disabled";
 
+		[TranslationReference("fps")]
+		const string FrameLimiter = "checkbox-frame-limiter";
 		static readonly int OriginalVideoDisplay;
 		static readonly WindowMode OriginalGraphicsMode;
 		static readonly int2 OriginalGraphicsWindowedSize;
@@ -227,7 +229,7 @@ Func<bool> InitPanel(Widget panel)
 			var frameLimitGamespeedCheckbox = panel.Get<CheckboxWidget>("FRAME_LIMIT_GAMESPEED_CHECKBOX");
 			var frameLimitCheckbox = panel.Get<CheckboxWidget>("FRAME_LIMIT_CHECKBOX");
 			var frameLimitOrigLabel = frameLimitCheckbox.Text;
-			var frameLimitLabel = new CachedTransform<int, string>(fps => frameLimitOrigLabel + $" ({fps} FPS)");
+			var frameLimitLabel = new CachedTransform<int, string>(fps => TranslationProvider.GetString(FrameLimiter, Translation.Arguments("fps", fps)));
 			frameLimitCheckbox.GetText = () => frameLimitLabel.Update(ds.MaxFramerate);
 			frameLimitCheckbox.IsDisabled = () => ds.CapFramerateToGameFps;
 

diff --git a/mods/cnc/chrome/settings-display.yaml b/mods/cnc/chrome/settings-display.yaml
@@ -288,7 +288,6 @@ Container@DISPLAY_PANEL:
 									Width: PARENT_RIGHT
 									Height: 20
 									Font: Regular
-									Text: Enable Frame Limiter
 						Container@FRAME_LIMIT_SLIDER_CONTAINER:
 							Width: PARENT_RIGHT / 2 - 20
 							Children:

diff --git a/mods/common/chrome/settings-display.yaml b/mods/common/chrome/settings-display.yaml
@@ -297,7 +297,6 @@ Container@DISPLAY_PANEL:
 									Width: PARENT_RIGHT
 									Height: 20
 									Font: Regular
-									Text: Enable Frame Limiter
 						Container@FRAME_LIMIT_SLIDER_CONTAINER:
 							Width: PARENT_RIGHT / 2 - 20
 							Children:

diff --git a/mods/common/languages/en.ftl b/mods/common/languages/en.ftl
@@ -351,6 +351,8 @@ options-target-lines =
     .manual = Manual
     .disabled = Disabled
 
+checkbox-frame-limiter = Enable Frame Limiter ({ $fps } FPS)
+
 ## HotkeysSettingsLogic
 label-original-notice = The default is "{ $key }"
 label-duplicate-notice = This is already used for "{ $key }" in the { $context } context