Skip to content

Commit

Permalink
Remove redundant order copies.
Browse files Browse the repository at this point in the history
  • Loading branch information
pchote authored and abcdefg30 committed Nov 27, 2022
1 parent 0a4c416 commit 96e0f96
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions OpenRA.Game/Network/Connection.cs
Expand Up @@ -57,12 +57,12 @@ void IConnection.StartGame()

void IConnection.Send(int frame, IEnumerable<Order> o)
{
orders.Enqueue((frame, new OrderPacket(o.ToArray())));
orders.Enqueue((frame, new OrderPacket(o)));
}

void IConnection.SendImmediate(IEnumerable<Order> o)
{
immediateOrders.Enqueue(new OrderPacket(o.ToArray()));
immediateOrders.Enqueue(new OrderPacket(o));
}

void IConnection.SendSync(int frame, int syncHash, ulong defeatState)
Expand Down Expand Up @@ -230,14 +230,14 @@ void NetworkConnectionReceive()

void IConnection.Send(int frame, IEnumerable<Order> orders)
{
var o = new OrderPacket(orders.ToArray());
var o = new OrderPacket(orders);
sentOrders.Enqueue((frame, o));
Send(o.Serialize(frame));
}

void IConnection.SendImmediate(IEnumerable<Order> orders)
{
var o = new OrderPacket(orders.ToArray());
var o = new OrderPacket(orders);
sentImmediateOrders.Enqueue(o);
Send(o.Serialize(0));
}
Expand Down
2 changes: 1 addition & 1 deletion OpenRA.Game/Network/OrderIO.cs
Expand Up @@ -18,7 +18,7 @@ namespace OpenRA.Network
public class OrderPacket
{
readonly MemoryStream data;
public OrderPacket(Order[] orders)
public OrderPacket(IEnumerable<Order> orders)
{
// Orders may refer to actors that no longer exist by the time
// that the order is resolved. In order to ensure consistent
Expand Down

0 comments on commit 96e0f96

Please sign in to comment.