Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color validator is rejecting most colors on the ~left half of the color chooser. #10217

Closed
pchote opened this issue Dec 13, 2015 · 3 comments
Closed
Assignees

Comments

@pchote
Copy link
Member

pchote commented Dec 13, 2015

This is silly. If we really do mean to be rejecting this much of the color space, then the picker should be adjusted to not show this area of rejected colors.

@pchote pchote modified the milestones: Next release, Next+1 Dec 13, 2015
@pchote pchote added Regression and removed Polish labels Jan 13, 2016
@pchote
Copy link
Member Author

pchote commented Jan 13, 2016

This is a more serious regression than I initially thought.
We are rejecting between half and three quarters of all the available colors (black areas are rejected):

validator

@ghost ghost changed the title Color validator is rejecting most colors on the ~left half of the color chooser. Color validator is rejecting most colors on the ~left half of the color chooser. [$15] Jan 21, 2016
@ghost ghost added the Bounty label Jan 21, 2016
@pchote pchote self-assigned this Jan 25, 2016
@pchote
Copy link
Member Author

pchote commented Jan 25, 2016

I have a branch that already fixes this, but I want to make it even better still before I PR it.

@pchote
Copy link
Member Author

pchote commented Jan 25, 2016

I am tacking this with a combination of changes:

  • Reducing the extreme threshold values that were introduced in 621cdeb
  • Only restricting colors that conflict with the main map colors (ground, water, resources) – turns out that the main problem were cliffs and roads!
  • Removing the validation against noncombatant players like neutral that were wiping out the low saturation colors.
  • Adding absolute S/L limits to chop off the deep greys and blacks (and trimming the color selection palette to match).

I've also increased the palette size to make colors easier to select:

screen shot 2016-01-25 at 22 52 14

@Mailaender Mailaender changed the title Color validator is rejecting most colors on the ~left half of the color chooser. [$15] Color validator is rejecting most colors on the ~left half of the color chooser. Nov 10, 2016
@Mailaender Mailaender removed the Bounty label Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants