WAV music issues.

[GraionDilach]

Carried over from #13763.

On bleed, music ends up silent, but still playing and the next track will return to be played at the volume it supposed to.

@RoosterDragon with your current music branch, I'm getting a crash-during-loading with OpenAL Error 40963.

[RoosterDragon]

I removed the strict error checks since they might not work on top of bleed anyway. It just has the logging now - give it another go.

[GraionDilach]

Hypnotic died in this run but I can't see anything out in the ordinary.

music.log

[RoosterDragon]

Looks like more logging is the first order of business then. I'll have to think about what to add.

[RoosterDragon]

@GraionDilach: Are you still able to reproduce this on current bleed?

[GraionDilach]

Dropped the ball on AS for some months now, but I'll do some tests ASAP.

[GraionDilach]

@RoosterDragon This bug is still happening but it's really hard to trigger these days, not as usual as it was when the ticket opened.

[RoosterDragon]

From the logs:

2017-10-14T09:06:31.9623006Z Starting music track Hypnotic
2017-10-14T09:06:31.9628054Z Streaming task is about to load audio.
2017-10-14T09:06:32.0108349Z Reclaiming source for a completed OpenAlAsyncLoadSound

I wonder if as Hypnotic started, some race condition allowed the audio source for it to be reclaimed, hence the lack of audio?

I have added the source IDs into the logging, so we can see if that is the case (it could be a different ID is getting reclaimed, which is normal).

I can't repro this on my system, so you'll need to try the updated logging. Sorry I can't offer any better suggestions.

(Rebased the logging onto master, https://github.com/RoosterDragon/OpenRA/tree/sound-logging)

[GraionDilach]

At this point I am really considering of creating some sort of a public and more straightforward testing environment because it didn't caught anything out of the ordinary either while the song was cut in the middle.

The sole thing I noticed out of interest was that when the game cuts the song itself during menu->game transition, the buffer is only reclaimed after the song would have ended on it's own anyway.

[GraionDilach]

Note that considering I have seen this bug at one point during the RV streams, I think this happens when too many audio played at the same time and the game drops the music instead of a particular sound.

[dnqbob]

Note that considering I have seen this bug at one point during the RV streams, I think this happens when too many audio played at the same time and the game drops the music instead of a particular sound.

I also think so.

[Smittytron]

Closing per: #19660 (review)