New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAV music issues. #14153

Open
GraionDilach opened this Issue Oct 8, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@GraionDilach
Contributor

GraionDilach commented Oct 8, 2017

Carried over from #13763.

On bleed, music ends up silent, but still playing and the next track will return to be played at the volume it supposed to.

@RoosterDragon with your current music branch, I'm getting a crash-during-loading with OpenAL Error 40963.

@Mailaender Mailaender added the Audio label Oct 8, 2017

@RoosterDragon

This comment has been minimized.

Show comment
Hide comment
@RoosterDragon

RoosterDragon Oct 11, 2017

Member

I removed the strict error checks since they might not work on top of bleed anyway. It just has the logging now - give it another go.

Member

RoosterDragon commented Oct 11, 2017

I removed the strict error checks since they might not work on top of bleed anyway. It just has the logging now - give it another go.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Oct 14, 2017

Contributor

Hypnotic died in this run but I can't see anything out in the ordinary.

music.log

Contributor

GraionDilach commented Oct 14, 2017

Hypnotic died in this run but I can't see anything out in the ordinary.

music.log

@RoosterDragon

This comment has been minimized.

Show comment
Hide comment
@RoosterDragon

RoosterDragon Oct 18, 2017

Member

Looks like more logging is the first order of business then. I'll have to think about what to add.

Member

RoosterDragon commented Oct 18, 2017

Looks like more logging is the first order of business then. I'll have to think about what to add.

@GraionDilach GraionDilach changed the title from Bleed music issues with WAV. to WAV music issues. Dec 16, 2017

@RoosterDragon

This comment has been minimized.

Show comment
Hide comment
@RoosterDragon

RoosterDragon Mar 29, 2018

Member

@GraionDilach: Are you still able to reproduce this on current bleed?

Member

RoosterDragon commented Mar 29, 2018

@GraionDilach: Are you still able to reproduce this on current bleed?

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Mar 29, 2018

Contributor

Dropped the ball on AS for some months now, but I'll do some tests ASAP.

Contributor

GraionDilach commented Mar 29, 2018

Dropped the ball on AS for some months now, but I'll do some tests ASAP.

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Apr 25, 2018

Contributor

@RoosterDragon This bug is still happening but it's really hard to trigger these days, not as usual as it was when the ticket opened.

Contributor

GraionDilach commented Apr 25, 2018

@RoosterDragon This bug is still happening but it's really hard to trigger these days, not as usual as it was when the ticket opened.

@RoosterDragon

This comment has been minimized.

Show comment
Hide comment
@RoosterDragon

RoosterDragon Apr 26, 2018

Member

From the logs:

2017-10-14T09:06:31.9623006Z Starting music track Hypnotic
2017-10-14T09:06:31.9628054Z Streaming task is about to load audio.
2017-10-14T09:06:32.0108349Z Reclaiming source for a completed OpenAlAsyncLoadSound

I wonder if as Hypnotic started, some race condition allowed the audio source for it to be reclaimed, hence the lack of audio?

I have added the source IDs into the logging, so we can see if that is the case (it could be a different ID is getting reclaimed, which is normal).

I can't repro this on my system, so you'll need to try the updated logging. Sorry I can't offer any better suggestions.

(Rebased the logging onto master, https://github.com/RoosterDragon/OpenRA/tree/sound-logging)

Member

RoosterDragon commented Apr 26, 2018

From the logs:

2017-10-14T09:06:31.9623006Z Starting music track Hypnotic
2017-10-14T09:06:31.9628054Z Streaming task is about to load audio.
2017-10-14T09:06:32.0108349Z Reclaiming source for a completed OpenAlAsyncLoadSound

I wonder if as Hypnotic started, some race condition allowed the audio source for it to be reclaimed, hence the lack of audio?

I have added the source IDs into the logging, so we can see if that is the case (it could be a different ID is getting reclaimed, which is normal).

I can't repro this on my system, so you'll need to try the updated logging. Sorry I can't offer any better suggestions.

(Rebased the logging onto master, https://github.com/RoosterDragon/OpenRA/tree/sound-logging)

@GraionDilach

This comment has been minimized.

Show comment
Hide comment
@GraionDilach

GraionDilach Apr 27, 2018

Contributor

At this point I am really considering of creating some sort of a public and more straightforward testing environment because it didn't caught anything out of the ordinary either while the song was cut in the middle.

The sole thing I noticed out of interest was that when the game cuts the song itself during menu->game transition, the buffer is only reclaimed after the song would have ended on it's own anyway.

Contributor

GraionDilach commented Apr 27, 2018

At this point I am really considering of creating some sort of a public and more straightforward testing environment because it didn't caught anything out of the ordinary either while the song was cut in the middle.

The sole thing I noticed out of interest was that when the game cuts the song itself during menu->game transition, the buffer is only reclaimed after the song would have ended on it's own anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment