Fix OpenAlSound.Complete being incorrect when OpenAl source is reused. #19660
Conversation
|
This might fix #14153. |
|
This makes sense - reuse of sources would make I think we may need to generalise this - if the source is going to be reclaimed, then I notice things like the I think in the general case that might explain #14153 as @Mailaender noted - if things were pausing or setting volume of a sound and actually setting some other sound by accident. |
|
I can't confirm that this is the root cause of #14153 but it wouldn't surprise me either. In any case it makes sense to be thorough here. I've adjusted the other methods to short out when the source is freed for reuse as well. |
There was a problem hiding this comment.
Sounds seem fine and music was able to switch tracks without anything going off kilter.
FWIW I would be happy to close the hard-to-repro issue if this is merged as it seems like a good candidate to resolve it. We can reopen if this doesn't turn out to be the fix.
I ran into this issue when trying to synchronize sequences to audio clips downstream. For that I needed to know when an audio clip has completed. When there are a lot of other sounds playing at the same time this would often go wrong.
The problem here is that OpenAlSound.Complete just looks at the status of the underlying OpenAl source. If another sound is started after the original sound has completed, the new sound might reuse the same underlying source. If the Complete method on the original sound is then evaluated again afterwards, it will return the status of the new sound instead of the original sound.
I added a simple boolean flag that gets set whenever the underlying source of the sound is reused, so that the Complete method will keep evaluating as true.