Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ProductionTypes from HashSet<string> to BitSet<ProductionType> #15403

Open
pchote opened this issue Jul 28, 2018 · 1 comment
Open

Convert ProductionTypes from HashSet<string> to BitSet<ProductionType> #15403

pchote opened this issue Jul 28, 2018 · 1 comment

Comments

@pchote
Copy link
Member

pchote commented Jul 28, 2018

This is another major gameplay system that is still stuck using HashSet.

@chrisforbes
Copy link
Member

chrisforbes commented Jul 29, 2018

A bunch of the things we would want to convert are currently restricted to a single value. Deferring a string -> bit value lookup to random runtime points is horrible -- it has to take a lock to ensure the bitset mapping isn't changing underneath it.

Do we want another type SingleBit<T> to go with BitSet<T> which can do this lookup at rules load time?

@chrisforbes chrisforbes removed their assignment Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants