Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load map crashes with no maps/no folder #15492

Closed
CH4Code opened this issue Aug 9, 2018 · 4 comments · Fixed by #15565
Closed

Load map crashes with no maps/no folder #15492

CH4Code opened this issue Aug 9, 2018 · 4 comments · Fixed by #15565
Labels

Comments

@CH4Code
Copy link
Contributor

CH4Code commented Aug 9, 2018

Short: When there are no maps present in the map folders the game crashes with an exception.

Reproduce
step 1: delete all maps from user/Openra/maps/mod/revision and programs/openra/mod/maps (except shellmaps).
step 2: press load map button in main menu

Noticed this while rebuilding a new mod with ModSDK on a second computer.

Expected: Load maps shows empty screen instead of crashing.

Exception Detail:

  Exception of type `System.InvalidOperationException`: Die Sequenz enthält kein übereinstimmendes Element.
     bei System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
   bei OpenRA.MapCache.ChooseInitialMap(String initialUid, MersenneTwister random) in e:\GitExt\OpenRAModSDK\engine\OpenRA.Game\Map\MapCache.cs:Zeile 333.
   bei OpenRA.Mods.Common.Widgets.Logic.MapChooserLogic..ctor(Widget widget, ModData modData, String initialMap, MapClassification initialTab, Action onExit, Action`1 onSelect, MapVisibility filter) in e:\GitExt\OpenRAModSDK\engine\OpenRA.Mods.Common\Widgets\Logic\MapChooserLogic.cs:Zeile 135.
...
@noamyogev84
Copy link
Contributor

I would like to investigate it. Can I be assigned for this issue?

@GraionDilach
Copy link
Contributor

@noamyogev84 Just file a PR, we don't use assignments much.

@noamyogev84
Copy link
Contributor

@CH4Code @GraionDilach just pinging you guys to kindly ask for your observation on my PR

@GraionDilach
Copy link
Contributor

I will probably find time to look into PRs tomorrow evening or Sunday. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants