You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The entering-cell warning appears to be running much later than it should be, leaving infantry insufficient time to move. Regressed somewhere between playtest-20190825 and playtest-20191021.
Bisect suggests that this was introduced by 4f884f9, and restoring that check does seem to fix this issue. It seems that case was important, although its not immediately obvious to me how we get from that to INotifyCrushed.WarnCrush.
The text was updated successfully, but these errors were encountered:
The solution would be to have it check if its a subcell unit, if I remember
correctly it behaved diffrently when it was a subcell unit than a fullcell,
didn't think it would make any diffrence. I can fill a pr with a fix
tomorrow.
On Mon, Oct 28, 2019, 23:09 Paul Chote ***@***.***> wrote:
The entering-cell warning appears to be running much later than it should
be, leaving infantry insufficient time to move. Regressed somewhere between
playtest-20190825 and playtest-20191021.
Bisect suggests that this was introduced by 4f884f9
<4f884f9>,
so it seems that case *was* important, although its not immediately
obvious to me how we get from that to INotifyCrushed.WarnCrush.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#17290?email_source=notifications&email_token=AESI7GDMJ2QJHRX6GVRQISDQQ5PJVA5CNFSM4JGAXSDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HU4VVZQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AESI7GAFOFMPIRR4G52ADP3QQ5PJVANCNFSM4JGAXSDA>
.
The entering-cell warning appears to be running much later than it should be, leaving infantry insufficient time to move. Regressed somewhere between
playtest-20190825
andplaytest-20191021
.Bisect suggests that this was introduced by 4f884f9, and restoring that check does seem to fix this issue. It seems that case was important, although its not immediately obvious to me how we get from that to
INotifyCrushed.WarnCrush
.The text was updated successfully, but these errors were encountered: