Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS - EMP Cannon can be bypassed cooldown via ForceFire #20828

Closed
MlemandPurrs opened this issue Apr 29, 2023 · 2 comments · Fixed by #21133
Closed

TS - EMP Cannon can be bypassed cooldown via ForceFire #20828

MlemandPurrs opened this issue Apr 29, 2023 · 2 comments · Fixed by #21133

Comments

@MlemandPurrs
Copy link

In Tiberian Sun mod, build the E.M. Pulse Cannon, ensure you have positive Power, select it now CTRL click on ground weapon fires via Force Attack, bypassing it's attached AttackOrderPower.

Expectation:
it should only able to fire through the AttackOrderPower when its ready.

@abcdefg30
Copy link
Member

From the discussion on Discord: Ideally we pause AttackBase while the power is charging. Unfortunately the power starts recharging before the weapon fires so this is not doable until the support power code is rewritten to account for that.

@penev92
Copy link
Member

penev92 commented Oct 18, 2023

From the discussion on Discord I think it became apparent that there is no "ideally".
I'll leave my finishing statement from there here as well:

IMO it's not completely off the table to cut our loses and decide that SupportPower code and attack code should not touch and just have the EMPCannon have its own hardcoded logic like all other powers so it doesn't use regular attacking
... aaaand then we can focus on having a semi-good mechanic for SP/SPInstance/SPManager knowing when a SP activation has started (successfully) and when it has ended

Also not mixing those two issues is important:

  • whether a SP activated successfully or was cancelled during activation
  • when the SP finished its activation (for SPs with non-instant effect)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants