Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paratroopers have 2 shadows #7603

Closed
Micr0Bit opened this issue Mar 6, 2015 · 6 comments · Fixed by #19315
Closed

paratroopers have 2 shadows #7603

Micr0Bit opened this issue Mar 6, 2015 · 6 comments · Fixed by #19315

Comments

@Micr0Bit
Copy link
Member

Micr0Bit commented Mar 6, 2015

paratroops

@deniz1a
Copy link
Contributor

deniz1a commented Mar 7, 2015

Is one of them for the parachute?

@Nelax
Copy link
Contributor

Nelax commented Mar 7, 2015

I'd wager the upper one is from the rifleman and the bottom one is the parachute. The logical solution is to not have it draw shadows for infantry while they are being paradropped.

@reaperrr
Copy link
Contributor

No, both shadows are for the rifleman. One is the shadow inside the e1.shp (the one on its feet), one is a separate shadow image at ground level for paradropped units.

The logical solution is to not have it draw shadows for infantry while they are being paradropped.

Agreed, or even better, this should be toggle-able at yaml level for any actor. This is the part that no one has bothered to deal with yet.

@DaynosaurusRex
Copy link
Contributor

Had a look at supporting this at the yaml layer; one idea is to have a "WithoutShadow" trait. As mentioned though, the shadow itself is baked in to the asset. Is there any way of multiplying it out? So call ".Except()" across a few of the palettes. Feels hacky though. Is there a better way?

@GraionDilach
Copy link
Contributor

A hackish - however more feasible - approach could be to duplicate the frame without shadow into a new SHP, include it and upgrade WithInfantryBody to WithSpriteBody with the parachute upgrade.

@ghost
Copy link

ghost commented Oct 2, 2019

Present in release-20190314.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants