Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RA infantry shadow being visible when parachuting #19315

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

reaperrr
Copy link
Contributor

@reaperrr reaperrr commented Apr 4, 2021

Thanks to TransparentIndex, this doesn't require custom sprites or similar gymnastics anymore.

Closes #7603

@Smittytron
Copy link
Member

Smittytron commented Apr 4, 2021

We'll need GNRL too. That one is paradropped in the mission Personal War.

@reaperrr
Copy link
Contributor Author

reaperrr commented Apr 4, 2021

Added GNRL and DOG (Chitzkoi).

Copy link
Member

@abcdefg30 abcdefg30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and works ingame.

@@ -52,10 +52,14 @@ DOG:
MoveSequence: walk
StandSequences: stand
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this is already the default, which we could remove. On the other hand we have this in a lot of places (almost all WIB in the diff of this PR have it), so not an issue we need to solve in this PR imo.

mods/ra/rules/infantry.yaml Show resolved Hide resolved
Copy link
Member

@Smittytron Smittytron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Smittytron Smittytron merged commit eec7de4 into OpenRA:bleed Apr 4, 2021
@reaperrr reaperrr deleted the fix-para-shadows branch July 2, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paratroopers have 2 shadows
3 participants