Fix DamagedWithoutFoundation causing more damage than it should

[abcdefg30]

to its damaged animation.

Unfortunately I didn't find a better way to fix the issue than two RunAfterTicks.
If we don't want to use that, I can remove the first commit, as the second one will hide the issue.

EDIT: Outdated description.

[pchote]

It looks like the nested RunAfterTicks is simply working around some other code which uses only one RunAfterTick that otherwise overrides the animation state. Can you work out what the other code is, and fix that instead?

[abcdefg30]

Updated.
After some more debugging I found the real issue (and fixed it):
Tick already decreased the health in addition to the decrement in AddedToWorld.

I still wonder why the animation wasn't changed to "damaged-" in the first place, though.

[pchote]

Confirmed that this fixes the initial flicker when repairing a newly placed structure.

There is another issue however: the damage warhead always applies a fixed amount of damage, so it can still push the building below the damage threshold if it is repaired slightly and then allowed to decay again.

[pchote]

This doesn't appear to be related to this pr at all.

[obrakmann]

Well, it works. 👍 after pchote's comments have been addressed.

[pchote]

There is another issue however: the damage warhead always applies a fixed amount of damage, so it can still push the building below the damage threshold if it is repaired slightly and then allowed to decay again.

Note that i'm not asking for this to be fixed now. That would up the complexity of this pr to the point where we shouldn't take it for the release (but i'd also be okay with too, if you did want to do everything together).

[abcdefg30]

Updated.

[penev92]

👍

[penev92]

Changelog