Replace MiniTK.Graphics with custom OpenGL shim. #10288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may also fix #7622 (which was closed prematurely). |
|
I don't see any faster startup, but the more light weight dependencies are still very much appreciated. 👍 We should get rid of the unnecessary parts from SDL2-CS and OpenTK.OpenAL as well. |
pchote
force-pushed
the
remove-minitk
branch
from
6781405
to
72d5c07
Compare
|
Rebased. |
pchote
force-pushed
the
remove-minitk
branch
4 times, most recently
from
71fde9a
to
2d71ccf
Compare
|
Updated to drop the OpenRA.Constants enum. The constants are now defined on the class for consistency with OpenAL-CS, which will be introduced in the next pr. |
| // ClearBufferMask | ||
| public const int GL_COLOR_BUFFER_BIT = 0x4000; | ||
| public const int GL_DEPTH_BUFFER_BIT = 0x0100; | ||
| public const int GL_STENCIL_BUFFER_BIT = 0x0400; |
|
The code looks good to me and everything renders ingame. 👍 |
pchote
force-pushed
the
remove-minitk
branch
from
2d71ccf
to
397ca0f
Compare
|
Fixed. |
|
Merging with this comment from @reaperrr: |
phrohdoh
added a commit
that referenced
this pull request
Dec 27, 2015
Replace MiniTK.Graphics with custom OpenGL shim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the ~30k line monster that's hidden in our custom sdl2-cs.dll with a minimal shim that only exposes the functionality that we actually need and uses the proper c-style conventions. This removes the relatively long delay (at least on my machine) between window creation and first render, and gets us a step closer to being able to use the "official" sdl2-cs library.
Depends on #10249 which currently makes up the first 6 commits in this pr (don't review these here!).