Remove Game.ModData references from Widget code. #10788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.onStart = onStart; | ||
| this.onExit = onExit; | ||
|
|
||
pchote
force-pushed
the
widget-moddata
branch
from
b37a88a
to
0907081
Compare
|
Fixed. |
|
👍 |
|
pchote
force-pushed
the
widget-moddata
branch
from
0907081
to
215ae7f
Compare
|
Fixed. |
|
Needs a rebase as well |
pchote
force-pushed
the
widget-moddata
branch
from
215ae7f
to
a6c4eb3
Compare
|
Rebased. |
|
Looks good to me, 👍 |
obrakmann
added a commit
that referenced
this pull request
Feb 25, 2016
Remove Game.ModData references from Widget code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main focus of this change is code hygiene (relying on a static reference for something which may change isn't nice), but has a side-effect of adding support for map-defined resources in the editor.