Overhaul RA installed content. #11545
Conversation
|
backwards compatibility (new playtest <-> last release and new bleed <-> older bleed) is going to be a problem here, and the migrations code won't be able to help. I think our only viable option will be to namespace the assets by putting them in a different directory. |
|
In Ruby On Rails, migrations used to have an |
|
I don't think that's worth the effort, and honestly would probably give up on finishing this rework if that became a requirement. The main reason this sucks so badly is that our old package setup is full of years of hacks and technical debt. Once everyone migrates to a consistent and non-mangled set of packages then future changes should be limited to simple additions (if we need assets in mix files that aren't included). |
|
No, it's cool, I'm fine with an "upgrades only"-policy. The mod browser should enforce that then, though, otherwise we'd probably get flooded with bug reports. |
|
Yup, that's why I added the changes requested tag. I'm going to wait for #11536 before I touch this again. |
This reverts commit c204c10.
| @@ -240,10 +240,12 @@ ModContent: | |||
| TestFiles: ^Content/ra/v2/expand/expand2.mix, ^Content/ra/v2/expand/hires1.mix, ^Content/ra/v2/expand/lores1.mix, ^Content/ra/v2/expand/chrotnk1.aud, ^Content/ra/v2/expand/fixit1.aud, ^Content/ra/v2/expand/jburn1.aud, ^Content/ra/v2/expand/jchrge1.aud, ^Content/ra/v2/expand/jcrisp1.aud, ^Content/ra/v2/expand/jdance1.aud, ^Content/ra/v2/expand/jjuice1.aud, ^Content/ra/v2/expand/jjump1.aud, ^Content/ra/v2/expand/jlight1.aud, ^Content/ra/v2/expand/jpower1.aud, ^Content/ra/v2/expand/jshock1.aud, ^Content/ra/v2/expand/jyes1.aud, ^Content/ra/v2/expand/madchrg2.aud, ^Content/ra/v2/expand/madexplo.aud, ^Content/ra/v2/expand/mboss1.aud, ^Content/ra/v2/expand/mhear1.aud, ^Content/ra/v2/expand/mhotdig1.aud, ^Content/ra/v2/expand/mhowdy1.aud, ^Content/ra/v2/expand/mhuh1.aud, ^Content/ra/v2/expand/mlaff1.aud, ^Content/ra/v2/expand/mrise1.aud, ^Content/ra/v2/expand/mwrench1.aud, ^Content/ra/v2/expand/myeehaw1.aud, ^Content/ra/v2/expand/myes1.aud | |||
| Sources: aftermath, aftermath-linux, tfd, ra-origin | |||
| Required: true | |||
| Download: aftermath | |||
There was a problem hiding this comment.
Aftermath wasn't released as freeware, was it?
There was a problem hiding this comment.
Not explicitly, no. Nobody seems to care about that fact though and it is far too late for us to remove our dependency on its assets.
There was a problem hiding this comment.
Well, we're shipping it already, this is just changing the mode of delivery, so to speak. Guess we'll have to live with it.
|
Looks fine, 👍 |
| . | ||
| $ra: ra | ||
| $cnc: cnc | ||
| ./mods/common: common | ||
| ~main.mix | ||
| ~redalert.mix |
There was a problem hiding this comment.
This makes the game not detect manually copied installations and attempt to download redundant files.
There was a problem hiding this comment.
Guess this is a trade-off for better performance. #11741
There was a problem hiding this comment.
one of the pr goals is to guarantee a standard set of installed assets. Calling this a feature might be a bit far, but it's certainly not an unwanted side effect.
|
This regressed the RA shellmap slightly, there's now a tile error on the river near the right soviet base. Probably a missing file that somehow didn't get included in the RA desert content download. |
This overhauls the RA asset extraction and downloads with a few goals in mind:
Depends on #11536.
Closes #11537.