Check that noiseDirection is not a zero #11670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,6 +111,10 @@ void RescanForTargets(Actor self) | |||
|
|
|||
| while (!self.World.Map.Contains(moveTo) || !mobile.CanEnterCell(moveTo, null, false)) | |||
| { | |||
| // without this check, this while statement can be infinity loop | |||
There was a problem hiding this comment.
It would be better to move the (moveTo == self.Location) check below inside this loop instead. That will catch the error case faster, and cancel the activity before returning.
There was a problem hiding this comment.
move the (moveTo == self.Location)
not moved, but copied this check into while statement and leave additional check after while statement.
check latest value after while loop too
evgeniysergeev
changed the title
| @@ -111,6 +111,13 @@ void RescanForTargets(Actor self) | |||
|
|
|||
| while (!self.World.Map.Contains(moveTo) || !mobile.CanEnterCell(moveTo, null, false)) | |||
| { | |||
| // without this check, this while can be infinity loop | |||
| if (moveTo == self.Location) | |||
There was a problem hiding this comment.
How can the sandworm ever end up at a location that is either not in the map, or that it cannot enter?
There was a problem hiding this comment.
Spawner outside the cordon, or on a cell with another actor?
|
Fair enough. 👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix unexpected freezes that can happen because of infinity loop in RescanForTargets