Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose some sound streams #12499

Merged
merged 1 commit into from Dec 24, 2016
Merged

Dispose some sound streams #12499

merged 1 commit into from Dec 24, 2016

Conversation

RoosterDragon
Copy link
Member

Make sure we dispose these streams as soon as we are done with them, rather than having to let the finalizer clear them up.

obrakmann
obrakmann approved these changes Dec 23, 2016
View reviewed changes
Copy link
Contributor

@obrakmann obrakmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

GraionDilach
GraionDilach approved these changes Dec 24, 2016
View reviewed changes
Copy link
Contributor

@GraionDilach GraionDilach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@obrakmann obrakmann merged commit 8977a56 into OpenRA:bleed Dec 24, 2016
@obrakmann
Copy link
Contributor

Changelog

@RoosterDragon RoosterDragon deleted the sound-dispose branch December 28, 2016 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GraionDilach GraionDilach GraionDilach approved these changes

@obrakmann obrakmann obrakmann approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RoosterDragon @obrakmann @GraionDilach