New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D2k extended upgradetooltips #12547
D2k extended upgradetooltips #12547
Conversation
@@ -23,6 +23,8 @@ concretea: | |||
Building: | |||
Footprint: xx xx | |||
Dimensions: 2,2 | |||
Tooltip: | |||
Name: Concret Slab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing an 'e' here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it by changing the file and using git rebase -i HEAD~3
pick
-> fixup
command.
Is there a better way?
0abfa85
to
7b674cd
Compare
|
7b674cd
to
f6e865d
Compare
uaaah sorry I will try to fix this :S |
f6e865d
to
2189882
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 after the nit addressed.
@@ -259,7 +259,7 @@ upgrade.heavy: | |||
BuildLimit: 1 | |||
BuildDuration: 380 | |||
BuildDurationModifier: 40 | |||
Description: Unlocks advanced technology and heavy weapons | |||
Description: Unlocks additional construction options \n(Repair Pad, IX Research Centre) \n\nUnlocks additional heavy units \n(Siege Tank, Missile Tank, MCV) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still Centre.
2189882
to
b1a1464
Compare
nit fixed |
Thanks! |
PR for #12069
Quite simple changes to the d2k yaml-files.
I added also a small fix for the combat tank tooltip:
If unwanted it will be deleted.