More sysinfo stuff #12649
More sysinfo stuff #12649
Conversation
| @@ -49,6 +49,7 @@ protected enum MenuType { Main, Singleplayer, Extras, MapEditor, SystemInfoPromp | |||
| { "x64", Pair.New("64bit OS", Environment.Is64BitOperatingSystem.ToString()) }, | |||
| { "runtime", Pair.New(".NET Runtime", Platform.RuntimeVersion) }, | |||
| { "gl", Pair.New("OpenGL Version", Game.Renderer.GLVersion) }, | |||
| { "windowsize", Pair.New("Window Size", "{0}x{1}".F(Game.Renderer.Resolution.Width.ToString(), Game.Renderer.Resolution.Height.ToString())) }, | |||
There was a problem hiding this comment.
The .ToStrings() shouldn't be needed here?
There was a problem hiding this comment.
My MD says Width and Height are ints.
Edit: Oh, you mean, it gets called automatically. Right. Will fix.
There was a problem hiding this comment.
Yeah, but this is a format string so there shouldn't be a problem there.
| Uri.EscapeUriString(Game.Mods["modchooser"].Metadata.Version), | ||
| Uri.EscapeUriString(Game.ModData.Manifest.Id), | ||
| Uri.EscapeUriString(Game.ModData.Manifest.Metadata.Version)); | ||
| Uri.EscapeUriString(Game.ModData.Manifest.Metadata.Version), | ||
| Uri.EscapeUriString(SystemInformationVersion.ToString())); |
There was a problem hiding this comment.
This might be better in the if case below. Not much use knowing this if there isn't any data to go with it.
obrakmann
force-pushed
the
more-sysinfo-stuff
branch
from
a4d1003
to
befd799
Compare
|
I feel bad for scope creeping this again, bug can you please include 029e0c3 here and add a column for it in OpenRA/OpenRAMasterServer#38? I should have thought about this when filing #12630. |
pchote
force-pushed
the
more-sysinfo-stuff
branch
from
befd799
to
51973cd
Compare
|
I've rebased this and added two new commits for the window scale + tweaking 64 bit label. Hope you don't mind, but I wanted to unstick this. |
|
👍 |
Closes #12630.