Refactor SupplyTruck/AcceptsSupplies to *Cash traits

[reaperrr]

It's only used by our RA mod and no more likely to be used by any 3rd-party mod than any other RA-specific logic (less likely, in my opinion), so I think it can be moved to Mods.Cnc.

Renamed to more generic DeliversCash/AcceptsDeliveredCash and added Type/Stance tags instead.

[MustaphaTR]

Actually, i'm using Supply Truck logic on the D2K map i was working on which is currently on bleed, but will keep it on release when it happens.

I wouldn't mind much if this won't effect the Next but Next + 1. I don't think i would update the map anyway when that happens.

[reaperrr]

@MustaphaTR D2k currently needs the Mods.Cnc.dll anyway due to ProductionAirdrop, and I don't see that changing soon (not before Next+1 in any case).

[reaperrr]

Alternatively, we could keep it in Common and rename the trait to SupplyActor or SupplyDeliverer or DeliversSupplies.

[GraionDilach]

Considering that these could be used for the YR Grinder even, I'd say it just needs a tag property.

[MustaphaTR]

Yea, i keep forgetting that D2k read CnC dll.

But Graion is right, this is the closet thing we have to grinder. So keeping it on common, renaming it and adding a Type: support for AcceptsSupplies and SupplyTruck so multipile types can be used (both actual Supply Trucks and Grinder for example).

[reaperrr]

Updated as suggested.

[GraionDilach]

Ah, I forgot this doesn't have a stance check. May you add that as well? 👍 after it.

[GraionDilach]

👍

[Iamgoofball]

#13000

[pchote]

"Supplies" is still a mod-specific name (what's a supply?). Can you please change these to DeliversCash and AcceptsDeliveredCash or something similar?

[pchote]

This PR supersedes #5925, so that one can be dropped from the Future milestone after this is merged. It also checks another box from #6336.

[reaperrr]

Updated.

Note: Removing AcceptsSupplies from TS instead of renaming is intentional, that looks like copy-pasta from the early days of the mod.

Requested renaming has been applied.

[GraionDilach]

Probably you should also rename the DonateSupplies activity as well.

[reaperrr]

Probably you should also rename the DonateSupplies activity as well.

Done.

[GraionDilach]

👍 still stands.

[obrakmann]

👍

[obrakmann]

Changelog