Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and partially refactor TeslaZap #13475

Merged
merged 4 commits into from Jun 11, 2017
Merged

Fix and partially refactor TeslaZap #13475

merged 4 commits into from Jun 11, 2017

Commits on Jun 7, 2017

  1. Minor TeslaZap cleanup 

    Renaming timeUntilRemove to ticksUntilRemove makes it more clear and allows to drop the comment.
    @reaperrr
    reaperrr committed Jun 7, 2017
    Copy the full SHA
    bb511ac View commit details
    Browse the repository at this point in the history

  2. Remove unused 'initialized' bool from TeslaZap 

    It was never set to 'true', and doing so would break Duration > 1, so it's better to just remove it.
    @reaperrr
    reaperrr committed Jun 7, 2017
    Copy the full SHA
    e4ac9f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2017

  1. Refactor TeslaZap targeting 

    - made it target closest targetable position, instead of CenterPosition
- made target tracking optional (enabled by default)
- made tracking independent from whether damage has already been dealt
- cache target position and update it in Tick only if tracking
    @reaperrr
    reaperrr committed Jun 11, 2017
    Copy the full SHA
    5eea1ba View commit details
    Browse the repository at this point in the history

  2. Replace doneDamage bool in TeslaZap with DamageDuration 

    Allows it to deal continous damage via a single projectile.
    @reaperrr
    reaperrr committed Jun 11, 2017
    Copy the full SHA
    c3da361 View commit details
    Browse the repository at this point in the history