Allow queueing of BridgeRepair #13508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcecore
changed the title
pchote
reviewed
Jun 17, 2017
| @@ -97,7 +97,6 @@ public void ResolveOrder(Actor self, Order order) | |||
|
|
|||
| self.SetTargetLine(Target.FromOrder(self.World, order), Color.Yellow); | |||
|
|
|||
| self.CancelActivity(); | |||
There was a problem hiding this comment.
This will break non-queued repair orders!
Put this behind a !queued check instead of removing it - look at how Infiltrates etc do it.
|
We now expose order queuing in the primary UI, so these queued activity bugs are high priority. Adding to milestone. |
forcecore
force-pushed
the
QueueEngiRepairBridge
branch
from
6f93827
to
43f0577
Compare
|
Unqueueing fixed like Infiltrates.cs |
pchote
approved these changes
Jun 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes CancelActivity() in RepairsBridge trait so that engineers can be queued to take a safer detour path if necessary.
There's a catch though. The last move order just before RepairBridge seems to be ignored for some reason. You have to queue many move orders to see this patch in effect. I think it is a bug coming from Enter.cs + Move.cs which I think is beyond the scope. Hopefully, after activities are refactored, the problem will be gone.
Fixes #13471