New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow queueing of BridgeRepair #13508

Merged
merged 2 commits into from Jun 18, 2017

Conversation

Projects
None yet
3 participants
@forcecore
Contributor

forcecore commented Jun 14, 2017

This PR removes CancelActivity() in RepairsBridge trait so that engineers can be queued to take a safer detour path if necessary.

There's a catch though. The last move order just before RepairBridge seems to be ignored for some reason. You have to queue many move orders to see this patch in effect. I think it is a bug coming from Enter.cs + Move.cs which I think is beyond the scope. Hopefully, after activities are refactored, the problem will be gone.

Fixes #13471

@forcecore forcecore changed the title from Engineer repair activity can be queued to Allow queueing of BridgeRepair Jun 14, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Jun 17, 2017

Member

We now expose order queuing in the primary UI, so these queued activity bugs are high priority. Adding to milestone.

Member

pchote commented Jun 17, 2017

We now expose order queuing in the primary UI, so these queued activity bugs are high priority. Adding to milestone.

@pchote pchote added this to the Playtest featuring updated HitShapes milestone Jun 17, 2017

@forcecore

This comment has been minimized.

Show comment
Hide comment
@forcecore

forcecore Jun 17, 2017

Contributor

Unqueueing fixed like Infiltrates.cs

Contributor

forcecore commented Jun 17, 2017

Unqueueing fixed like Infiltrates.cs

@obrakmann

👍

@pchote

pchote approved these changes Jun 18, 2017

Works as advertised 👍

This gave me a good testcase to diagnose the problem with queued moves, which indeed has nothing to do with this PR.

@pchote pchote merged commit a3c9d72 into OpenRA:bleed Jun 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@forcecore forcecore deleted the forcecore:QueueEngiRepairBridge branch Jun 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment