New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish RA Jeep and APC muzzle offsets #13957

Merged
merged 1 commit into from Sep 2, 2017

Conversation

Projects
None yet
4 participants
@reaperrr
Contributor

reaperrr commented Aug 31, 2017

And Jeep turret offset.

The muzzle offsets had zero forward offset, which made the muzzle draw over - instead of in front of - the MG barrel.

Not a blocker for the playtest, but should go into release if possible, since this can't regress anything and adds some polish.

Polish RA Jeep and APC muzzle offsets
And Jeep turret offset.

@reaperrr reaperrr added this to the Next Release milestone Aug 31, 2017

@SoScared

SoScared approved these changes Sep 2, 2017 edited

Looks good. Big improvement upon the original muzzle offsets.

@SoScared

This comment has been minimized.

Show comment
Hide comment
@SoScared

SoScared Sep 2, 2017

Member

@Mailaender @pchote any chance for an added review before the playtest? It's a polish on two units used very frequently in RA.

Member

SoScared commented Sep 2, 2017

@Mailaender @pchote any chance for an added review before the playtest? It's a polish on two units used very frequently in RA.

@ltem

This comment has been minimized.

Show comment
Hide comment
@ltem

ltem Sep 2, 2017

Contributor

👍

Before After
image image
Contributor

ltem commented Sep 2, 2017

👍

Before After
image image
@ltem

ltem approved these changes Sep 2, 2017

@reaperrr reaperrr merged commit 96e98a2 into OpenRA:bleed Sep 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reaperrr reaperrr deleted the reaperrr:ra-muzzle-offsets branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment