New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some turret-related render traits #14023

merged 2 commits into from Sep 15, 2017


None yet
2 participants

reaperrr commented Sep 15, 2017

Split from #13619, as the uninterruptability part might need some more work and time.

Carrying over the +1 from @abcdefg30 since this part is uncontroversial, I think.

Remove 'ed' from WithTurretedAttackAnimation
Too confusing, as people might think it requires 'WithTurretedSpriteBody', also not entirely in line with our (admittedly implicit) render trait naming convention.
Rename and move WithTurretedSpriteBody
The name wasn't in line with our implicit naming convention and ambigous on top of that.
Also, only used by RA and TD so moved to Mods.Cnc.

pchote approved these changes Sep 15, 2017

@pchote pchote merged commit dbcfb0c into OpenRA:bleed Sep 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@reaperrr reaperrr deleted the reaperrr:rename-some-turret-rendertraits branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment