Add Support for dropping Cargo with Parachute from an Aircraft #14276
Conversation
|
MustaphaTR
force-pushed
the
paradrop-aircraft
branch
from
a629b7b
to
8dec5cb
Compare
MustaphaTR
force-pushed
the
paradrop-aircraft
branch
from
8dec5cb
to
aa29eaa
Compare
MustaphaTR
force-pushed
the
paradrop-aircraft
branch
from
aa29eaa
to
3aba424
Compare
|
|
||
| public override Activity Tick(Actor self) | ||
| { | ||
| var cargo = self.Trait<Cargo>(); |
There was a problem hiding this comment.
Please assign these from the constructor (passing Actor self as a parameter to query from) instead of looking it up ever tick.
| inu.Unloading(self); | ||
|
|
||
| var actor = cargo.Peek(self); | ||
| var spawn = self.CenterPosition; |
There was a problem hiding this comment.
This doesn't appear to check for suitable drop cells...?
There was a problem hiding this comment.
Current checks indeed doesn't seem right, but i'm not sure what exactly to do either, it makes more sense that Cargo -> CanUnload checks this, rather than ParadropCargo activity.
CanUnload already still checking for LandableTerrainTypes. I think this shouldn't be checked for them.
reaperrr
added
PR: Fixup requested
PR: Changes requested
and removed
PR: Fixup requested
labels
|
I don't think i'm gonna work on this soon, was a pretty hacky attempt anyway. |
I'm not sure how well the code is, may need help to make it better. But well it works.
Also maybe for another PR, but i think "unloadAll" should be able to settable on .yaml, i think would be cool. ParadropCargo acts a bit wierd with unloadAll = true tho (plane stays in midair for some ticks and cargo may die because of falling on each other). So it is false with this PR.
For Testcase, to ensure everthing works fine, i added a Badger, also gave ability to use parachute to Chinook, and gave Hind Cargo but without UnloadWithParachute tag.