Register the current mod even if LaunchPath is bogus. #14422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperrr
previously approved these changes
Dec 2, 2017
|
Ping @OpenRA/engine-hackers. This is an easy fix to a release blocking bug. |
|
For the record: I HAVE tested this, not just reviewed the code. |
pchote
force-pushed
the
fix-bogus-registration
branch
from
6ed2e29
to
35c153b
Compare
|
Rebased. Can we please get this merged? |
reaperrr
approved these changes
Dec 17, 2017
abcdefg30
approved these changes
Dec 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14186.
Testcase: Set the mod version to something with a bunch of online games, then launch the game with a bogus
Engine.Launchpath. Before: server list doesn't show any games for the current mod. After: it does.