New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the current mod even if LaunchPath is bogus. #14422

Merged
merged 1 commit into from Dec 17, 2017

Conversation

Projects
None yet
3 participants
@pchote
Member

pchote commented Nov 25, 2017

Fixes #14186.

Testcase: Set the mod version to something with a bunch of online games, then launch the game with a bogus Engine.Launchpath. Before: server list doesn't show any games for the current mod. After: it does.

@pchote pchote added this to the Next release milestone Nov 25, 2017

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 9, 2017

Member

Ping @OpenRA/engine-hackers. This is an easy fix to a release blocking bug.

Member

pchote commented Dec 9, 2017

Ping @OpenRA/engine-hackers. This is an easy fix to a release blocking bug.

@reaperrr

This comment has been minimized.

Show comment
Hide comment
@reaperrr

reaperrr Dec 9, 2017

Contributor

For the record: I HAVE tested this, not just reviewed the code.

Contributor

reaperrr commented Dec 9, 2017

For the record: I HAVE tested this, not just reviewed the code.

@pchote

This comment has been minimized.

Show comment
Hide comment
@pchote

pchote Dec 16, 2017

Member

Rebased. Can we please get this merged?

Member

pchote commented Dec 16, 2017

Rebased. Can we please get this merged?

@abcdefg30 abcdefg30 merged commit 1a405b1 into OpenRA:bleed Dec 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Show comment
Hide comment
@abcdefg30
Member

abcdefg30 commented Dec 17, 2017

@pchote pchote deleted the pchote:fix-bogus-registration branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment