New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2K - Allow all upgradable structures to build upgrades #14433

Merged
merged 2 commits into from Dec 18, 2017

Conversation

Projects
None yet
5 participants
@MustaphaTR
Member

MustaphaTR commented Nov 27, 2017

Fixes #12665. This doesn't cause upgrade tab to appear first when you deploy an MCV at the beginning of the game. (unlike moving it to Player: actor) But MCVless missions like Atr5 and Har9b show upgrades first, which i don't think much of a problem

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 2, 2017

Member

Hmm, i just noticed this still doesn't look correct. Selecting anything except Constrction Yard causes ProductionQueueFromSelection to select Upgrade tab. I guess it selects the first one according to order under Player: actor. We can fix that by 2 way:

1-) Move Upgrade tab to last under Player: actor. But this may effect other things, one that comes to my mind is order under Production spectator menu.
2-) Make it so ProductionQueueFromSelection uses the order at Production: > Produces: rather than Player: actor.

Member

MustaphaTR commented Dec 2, 2017

Hmm, i just noticed this still doesn't look correct. Selecting anything except Constrction Yard causes ProductionQueueFromSelection to select Upgrade tab. I guess it selects the first one according to order under Player: actor. We can fix that by 2 way:

1-) Move Upgrade tab to last under Player: actor. But this may effect other things, one that comes to my mind is order under Production spectator menu.
2-) Make it so ProductionQueueFromSelection uses the order at Production: > Produces: rather than Player: actor.

@MustaphaTR

This comment has been minimized.

Show comment
Hide comment
@MustaphaTR

MustaphaTR Dec 8, 2017

Member

Updated. Done 1.

Member

MustaphaTR commented Dec 8, 2017

Updated. Done 1.

@reaperrr reaperrr added this to the Next release milestone Dec 13, 2017

@ltem

I couldn't spot any issues and it works as advertised.

@pchote

pchote approved these changes Dec 18, 2017

@pchote pchote merged commit fe01afe into OpenRA:bleed Dec 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:d2k-upgrade-for-all branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment