Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D2K - Allow all upgradable structures to build upgrades #14433

Merged
merged 2 commits into from
Dec 18, 2017
Merged

D2K - Allow all upgradable structures to build upgrades #14433

merged 2 commits into from
Dec 18, 2017

Conversation

MustaphaTR
Copy link
Member

@MustaphaTR MustaphaTR commented Nov 27, 2017 •
edited
Loading

Fixes #12665. This doesn't cause upgrade tab to appear first when you deploy an MCV at the beginning of the game. (unlike moving it to Player: actor) But MCVless missions like Atr5 and Har9b show upgrades first, which i don't think much of a problem

@MustaphaTR MustaphaTR mentioned this pull request Nov 27, 2017
Merged
@MustaphaTR
Copy link
Member Author

Hmm, i just noticed this still doesn't look correct. Selecting anything except Constrction Yard causes ProductionQueueFromSelection to select Upgrade tab. I guess it selects the first one according to order under Player: actor. We can fix that by 2 way:

1-) Move Upgrade tab to last under Player: actor. But this may effect other things, one that comes to my mind is order under Production spectator menu.
2-) Make it so ProductionQueueFromSelection uses the order at Production: > Produces: rather than Player: actor.

@MustaphaTR
Copy link
Member Author

Updated. Done 1.

@reaperrr reaperrr added this to the Next release milestone Dec 13, 2017
ltem
ltem previously approved these changes Dec 17, 2017
View reviewed changes
Copy link
Contributor

@ltem ltem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't spot any issues and it works as advertised.

@MustaphaTR MustaphaTR force-pushed the d2k-upgrade-for-all branch 2 times, most recently from 9152259 to ee904c6 Compare December 18, 2017 18:32
@pchote pchote merged commit fe01afe into OpenRA:bleed Dec 18, 2017
@pchote
Copy link
Member

pchote commented Dec 18, 2017

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/f50341b09dd94e255ba8d5043db76afa9dfbd72a

@MustaphaTR MustaphaTR deleted the d2k-upgrade-for-all branch December 18, 2017 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@ltem ltem ltem left review comments

Assignees
No one assigned
Labels
PR: Is Dependency PR: Needs +2
Projects
None yet
Milestone
Release 20180218
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MustaphaTR @pchote @ltem @reaperrr @abcdefg30