Cache VariableExpressions on load. #14524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed that this provides a 10-15% improvement in RA startup time on macOS/mono 5.4.1.7. |
pchote
previously approved these changes
Dec 16, 2017
Compiling these expressions is sadly expensive, and we needed new ones for every trait on every actor each time one was generated. The expressions thankfully can be shared as they are pure functions, which removes this overhead.
RoosterDragon
force-pushed
the
cache-expressions
branch
from
f543381
to
a6b697d
Compare
|
(fixed naming to appease StyleCop) |
|
Reproduceably improves RA startup time by 20% (~2400ms vs. ~3000ms on bleed) on my system (Win10x64, msbuild-compiled debug build). |
reaperrr
approved these changes
Dec 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling these expressions is sadly expensive, and we needed new ones for every trait on every actor each time one was generated. The expressions thankfully can be shared as they are pure functions, which removes this overhead.
Saves 15% of CPU during initial game load (caused by loading actors for the RA shellmap). This would also save a bit of CPU when creating new actors during regular games too.