ActorSelectorLogic: Keep track of available owners. #14656
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LipkeGu
force-pushed
the
editor_prevent_crash_mpspawn
branch
from
271b5b7
to
bee54ae
Compare
LipkeGu
force-pushed
the
editor_prevent_crash_mpspawn
branch
from
bee54ae
to
e51738a
Compare
LipkeGu
changed the title
|
updated testcase: #9364 (comment) |
| .OrderBy(p => p.Name); | ||
|
|
||
| selectedOwner = (players.Count() != 0) ? | ||
| players.Last() : editorLayer.Players.Players.FirstOrDefault().Value; |
There was a problem hiding this comment.
Possibly simpler as:
var multiPlayer = editorLayer.Players.Players.Values
.Where(p => p.Name.StartsWith("Multi"))
.OrderByDescending(p => p.Name)
.FirstOrDefault();
selectedOwner = multiPlayer ?? editorLayer.Players.Players.First().Value;
|
Looks like a sensible approach overall. |
|
I will adress this and move this to Tick. |
|
Any progress here @LipkeGu? |
|
Closing in favour of #15628. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
OnUpdate()in ActorSelectorLogic so that theOwnersDropdown.Textgets updated when owners gets removed (by removing spawn points. It will first try to pick up the last "MultiX" entry otherwise when no "Multi" is found. it will use the first available owner (ex: Neutral).The next part of this PR is the Question "What should happen with placed) Actors
which was owned by a removed Owner?
fixes #9364