Pass ActorInfo through building-placement-validation code. #14955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdefg30
reviewed
Mar 20, 2018
| @@ -17,7 +17,7 @@ namespace OpenRA.Mods.Common.Traits | |||
| { | |||
| public static class BuildingUtils | |||
| { | |||
| public static bool IsCellBuildable(this World world, CPos cell, BuildingInfo bi, Actor toIgnore = null) | |||
| public static bool IsCellBuildable(this World world, CPos cell, ActorInfo ai, BuildingInfo bi, Actor toIgnore = null) | |||
There was a problem hiding this comment.
What is this change for? Just consistency with CanPlaceBuilding?
There was a problem hiding this comment.
This will be used by #14862 in addition to consistency.
abcdefg30
approved these changes
Mar 21, 2018
|
I guess this can be mentioned in the changelog of #14862 if it wants one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the messy plumbing changes from #14862 with a few extra changes that I would otherwise have left as review comments. I would prefer to split this out into its own PR so that #14862 can focus on the new behaviour.